search

HaikuArchives / ArtPaint

ArtPaint is a painting and image processing program.
https://haikuarchives.github.io/ArtPaint/
29 stars 18 forks source link

BlurTool: added "use current brush" option #511

Closed dsizzle closed 1 year ago

dsizzle commented 1 year ago

so, let me know what you think: this successfully uses the shape of the brush, but not the softness/hardness of it. Since it's blurring, it's all soft...but I can't figure out (so far) how to make the soft parts of a brush "less blurry" - does that matter in this case?

if so I will continue to work on it.

if not, I think this is the last tool that makes sense for #202 and #177 ?

dsizzle commented 1 year ago

actually I discovered really buggy behavior switching back and forth between using the brush and not:

ugh-blur

so, don't merge this. :laughing:

humdingerb commented 1 year ago

this successfully uses the shape of the brush, but not the softness/hardness of it. Since it's blurring, it's all soft...but I can't figure out (so far) how to make the soft parts of a brush "less blurry" - does that matter in this case?

Probably not. The checkmark label could be "Use current brush (size & shape)" to be perfectly honest with the user. :)

dsizzle commented 1 year ago

Ok, i think I fixed the crazy bad artifacts - please give it a try.

humdingerb commented 1 year ago

Works when "using current brush". Yay! Makes a mess when using the explicit Size-controlled tool tip. Oh noes!

dsizzle commented 1 year ago

:disappointed:

I thought I had fixed it because I switched back and forth many times with no problems, whereas before I could break it easily.

dsizzle commented 1 year ago

huh, seems like changing the size is what breaks it. weird. I must've broken the old code path.

dsizzle commented 1 year ago

Ok, now I think this is really fixed. After poring over and over the code for hours and this being the "smoking gun" between working and not, I hope this is it. It's an integer-vs-floating point issue.

humdingerb commented 1 year ago

The old integer vs. float conflict... why can't they just get along? :) Seems your peace negotiations were successful, or at least an armistice was reached. Blur tool appears to be in full working order. March!^W Merge!

[I'm in quite a good mood for a Monday, it appears...]