BrushStoreWindow: make blue selection outline thicker

[dsizzle]

also fixed redrawing, and cleaned up the code a tiny bit

Fixes #503

[humdingerb]

Have you tried other blue border width, too?

It went from 1-pixel (too small):

Right to 3-pixel:

A bit too thick IMO, also cuts a bit into the red size-rule at the bottom-left of each brush square.

Would 2-pixel be acceptable? Mockup:

Also, and you'll damn my magnifying retentiveness, the view borders don't meld into the window borders on the left, bottom, and the scrollbar to the right, so they appear too thick:

[dsizzle]

Yeah, I tried 2 pixels and I think there is some floating point rounding or the previews are weird sizes, because it is slightly off - nothing I tried would get it to line up, whereas 3 “just works.”

and yes, I do wish you would misplace your Magnifying glass. 🤣

[dsizzle]

Ok, I went with 1.5 pixels; it looks similar to the 2-pixel mockup, and I moved the red size bar up a little and shrank it from the right size so it centers better. I also added another pixel in-between brushes as they seemed too tightly-packed. Of course I fixed the offending 2-pixel borders on the scroll view as well.

[humdingerb]

Very nice merging borders. The blue frame isn't pixel perfect, but I understand it's not easy and one doesn't really see it. :)

One thing, is the blue colour. I think it should be using the same colour constant as the Tools window (ToolButton.cpp): B_KEYBOARD_NAVIGATION_COLOR However, that is actually a deprecated constant name and both should be changed to B_NAVIGATION_BASE_COLOR.

[dsizzle]

ok, updated to use the standard ui color for both

EDIT: I was gonna do a separate PR for the tool selection color but since it's SUCH a small change I'll go against my principles and include it here. :D

[humdingerb]

Very good. Nice optical illusion BTW: the blue appears darker in the Brushes window than in the Tools window. Magnify confirms it's the same 0,0,229 though. :) Merge!

[humdingerb]

Very good. Nice optical illusion BTW: the blue appears darker in the Brushes window than in the Tools window. Magnify confirms it's the same 0,0,229 though. :) Merge!