search

HaikuArchives / ArtPaint

ArtPaint is a painting and image processing program.
https://haikuarchives.github.io/ArtPaint/
29 stars 18 forks source link

Crop: removed all the +1s for bounds #558

Closed dsizzle closed 10 months ago

dsizzle commented 1 year ago

Seems to fix #552

...but could it be that easy?

I was trying to remember how it used to crash but I couldn't get it to crash even trying all sorts of weird sizes.

humdingerb commented 1 year ago

...but could it be that easy?

Of course not. :) Height and Width are now reporting one pixel short. The Deskbar test image from #552 is 187 x 267, but ArtPaint thinks it's 186 x 266. While the procedure described in #552 works correctly now, cropping to 1 x 1 actually gives a 2 x 2...

I have a dim memory that this was an issue you fixed before, probably introucing this very same issue you're solving now. :)

dsizzle commented 10 months ago

closing because this didn't fix the issue.