search

HaikuArchives / ArtPaint

ArtPaint is a painting and image processing program.
https://haikuarchives.github.io/ArtPaint/
29 stars 18 forks source link

WindowGUIManipulator: restore MessageReceived virtual function #615

Closed dsizzle closed 9 months ago

dsizzle commented 9 months ago

need to re-add this function after #613

dsizzle commented 9 months ago

merged without review; needed to fix missing runtime symbol

humdingerb commented 9 months ago

Sorry about that. I thought if the MessageReceived() just calls the parent class' (is that what you call it?), MessageReceived() function, it could just as well be removed...

dsizzle commented 9 months ago

parent or base. I can take the blame for this; I remember making a comment along the lines of being able to delete these types of functions. Without going into detail, in this case it's the inheritance chain - the derived classes (like the AddOns) need that virtual function.

humdingerb commented 9 months ago

Ah, sort of an inheritence tax we have to pay for the greedy add-on heirs...