search

HaikuArchives / ArtPaint

ArtPaint is a painting and image processing program.
https://haikuarchives.github.io/ArtPaint/
29 stars 18 forks source link

StraightLineTool: don't add 1 to even-numbered widths #620

Closed dsizzle closed 1 year ago

dsizzle commented 1 year ago

Addressed the "straight line" part of #618

For some strange reason the width had 1 added to it if it was an even number? No idea why but it seems to work fine without that.

humdingerb commented 1 year ago

Works worth width set in the straight line tool setup. If you "Use current brush" though you still get the same as described in #618::

"Width" = 1: shows as 1 pixel width/height "Width" = 2: shows as 3 pixel width/height "Width" = 3: shows as 3 pixel width/height "Width" = 4: shows as 5 pixel width/height "Width" = 5: shows as 5 pixel width/height "Width" = 6: shows as 7 pixel width/height

The same happens with "Use current brush" for the freehand tool.

dsizzle commented 1 year ago

You need to pull #619 to get the right behavior for the current brush.

this PR only fixes the straight line tool and needs to be merged in concert with #619

humdingerb commented 1 year ago

Oops, sorry, I thought #619 was merged before you created this PR. All works as intended with #619 added.

dsizzle commented 1 year ago

yay, merged. Thanks!