Clang fixes for 9/2023 - Githubissues

HaikuArchives / ArtPaint

ArtPaint is a painting and image processing program.

https://haikuarchives.github.io/ArtPaint/

29 stars 18 forks source link

Clang fixes for 9/2023 #622

Closed dsizzle closed 9 months ago

dsizzle commented 9 months ago

fixed several memory leaks
fixed bad deallocator
fixed undefined values
fixed NULL pointer accesses
removed dead initialization

Related to #124

dsizzle commented 9 months ago

merged directly without review since it's just static analysis fixes.

humdingerb commented 9 months ago

FWIW, I did jus check if it still compiles and launches. The changes in the code seem to be mostly unused variables, duplication and NULL checks. All above the most trivial things, I wouldn't trust myself to judge... :) Maybe I should just comment "Still builds" in the future. OTOH, I bet you already knew that...