search

HaikuArchives / Becasso

Paint and imaging software for Haiku, originally written for BeOS by Sum Software.
MIT License
3 stars 8 forks source link

Colour window: monochromatic and askew #30

Open humdingerb opened 2 years ago

humdingerb commented 2 years ago

Something's wrong with the colour panel:

colour_rgb

colour_hsv

pulkomandy commented 2 years ago

Can you try reverting https://cgit.haiku-os.org/haiku/commit/src/kits/interface/Bitmap.cpp?id=6211ae257544d7a1453bc34297c8eac3e2b0435d and see if it makes a difference?

humdingerb commented 2 years ago

Good catch! Reverting that commit does indeed fix the issue.

scottmc commented 1 year ago

Has Haiku been updated yet such that it has fixed this issue?

humdingerb commented 1 year ago

It has not, this issue is still with us. I have no idea if the commit @pulkomandy linked can easily be reverted and fixed another way, or if Becasso could be fixed more easily... As is, Becasso is pretty useless. Or at least, colourless... :)

pulkomandy commented 1 year ago

@jscipione do you have an opinion here? I think the previous code in BBitmap was behaving identically to BeOS at least for BeCasso case. So the fix for Spirograph is either incorrect or incomplete.

It wouldn't be difficult to fix BeCasso (use ImportBits instead of SetBits, probably) but it would be nice to try to have the old SetBits behave as close as possible to BeOS still?