HaikuArchives / Calendar

:calendar: A native Calendar application for Haiku.
MIT License
29 stars 20 forks source link

Application name not translated in all catkeys files. It is around line 98 #84

Closed bitigchi closed 2 years ago

bitigchi commented 3 years ago

It stays as Calendar in Tracker and Deskbar.

harshit-sharma-gits commented 2 years ago

Hello, Harshit Sharma this side, can I work on this issue?

pulkomandy commented 2 years ago

Yes, your help is welcome. You need to use B_TRANSLATE_SYSTEM_NAME in the appropriate places. This guide can be helpful: https://www.haiku-os.org/community/getting-involved/translating/3rdparty/

harshit-sharma-gits commented 2 years ago

Thanks! I'll check the resource out and get back to it.

harshit-sharma-gits commented 2 years ago

Hello, can you please elaborate what we are going to do, I mean do we have to change the Application name from Calendar to something else?

scottmc commented 2 years ago

The issue here seems to be that some of the submitted catkeys files do not have line 98 Calendar translated. If those are updated, it works as expected. Well at least the name on the applications Tab changes to the translated word. Not sure about its icon or how it shows up in Deskbar. I'm not seeing any applications names changing in my deskbar when i switch locales, but they change in preferences? Maybe @humdingerb knows why I'm not seeing those changes. Anyways renaming this to reflect need to get the catkeys files fixed up.

humdingerb commented 2 years ago

The catkeys are translated at https://i18n.kacperkasper.pl/projects/28 Translated app names don't appear in the Deskbar. That's a reported bug at Haiku's Trac. For app names the macro B_TRANSLATE_SYSTEM_NAME() has to be used in the code, not B_TRANSLATE().

scottmc commented 2 years ago

B_TRANSLATE_SYSTEM_NAME() is already in the code. Turns out it was just not translated in the de.catkeys file, perhaps others. If the translation team(s) for affected languages want to have the app name change, i'll defer to them. Closing this as won't fix, as the app don't have the bug.

bitigchi commented 2 years ago

I have it translated in the Turkish cat file, but it's still not displayed in Turkish. Surely there is a bug somewhere? This issue was opened because it was translated.

humdingerb commented 2 years ago

As I wrote earlier: "Translated app names don't appear in the Deskbar. That's a reported bug at Haiku's Trac."