search

HaikuArchives / Hare

Haiku Audio Ripper/Encoder.
MIT License
4 stars 8 forks source link

Made Changes To Editor View #11

Closed friedy10 closed 6 years ago

scythx commented 6 years ago

Looks good!

I think you forget to add genreBox to the layout.

And let's take a look here https://github.com/HaikuArchives/Hare/pull/11/files#diff-c6bc2525885396f78b54e66cc6ccddd1R38

-   PRINT(("EditorView::EditorView(BRect)\n"));
+        PRINT(("EditorView::EditorView(BRect)\n"));

As you could see, it only change indentation level and i think that change is not necessary, it make your code hard to review. and there's bunch of it in your code and i suggest you to fix it.

And to fix #1 you need to convert all files that contain interface not only the EditorView.cpp.

scottmc commented 6 years ago

Yes, the Genre box is missing. Also the boxes should be much wider. See if you can put all 7 in one list aligned on the left, perhaps adding a scroll view to allow having more than 7 in the future. Once more tags are enabled via musicbrainz this could have a whole lot more fields possible. Nice work so far.

scottmc commented 6 years ago

Going to accept this as is and will open another task to finish up the conversion and this have already been a nice improvement.