search

HaikuArchives / KeyCursor

Using a Keyboard as a Pointing Device
Other
3 stars 3 forks source link

Is disabling the KeyCursorFilter via prefs panel needed? #5

Closed humdingerb closed 10 months ago

humdingerb commented 10 months ago

I can imagine the current checkbox to disable/enable KeyCursor in the preference panel could be handy when debugging. (Though maybe quickly use the un/install.sh scripts is enough for that as well?)

Opinions? @OscarL ?

OscarL commented 10 months ago

I can't recall exactly why I've added it back in the day, other than installing/uninstalling was more disruptive, as it involved restarting input_server (sometimes rendering the system unusable), or to avoid toggling it on by mistake (being the lousy typist that I am :-D).

I guess I can re-add it on my own fork if I ever miss it.

humdingerb commented 10 months ago

In my PR I (accidentally) also committed a change to install.sh that commented out the restart of input_server. That always hangs my system, and apparently when newly built filter/device binaries are copied to their (non-packaged) location, they get reloaded. So, no need to restart input_server.

I suppose if you want to disable KeyCursor temporarily, you could just as well un-tick the checkboxes of the toggle keys as you would the "Enable KeyCursor" checkbox.

I'd like to the move the "Enable" checkbox, because it causes a bit of confusion with the toggle key settings.

humdingerb commented 10 months ago

The "Enable" checkbox was removed with 13e0292b4e0133313130b878214d49eb3e41687b . The code is, as of yet, only commented out.