search

HaikuArchives / Paladin

Paladin is an open source integrated development environment (IDE) for Haiku OS
MIT License
64 stars 20 forks source link

Current source checkout fails with a parse error on gcc2 #375

Open Begasus opened 4 years ago

Begasus commented 4 years ago

This is with: https://github.com/adamfowleruk/Paladin/blob/develop/Paladin/PreviewFeatures/CommandOutputHandler.h#L29

https://paste.ubuntu.com/p/YPfQTXsdtp/

EDIR Stripping "override" on that line fixes the build (but I'm pretty sure it's not the correct sollution ;)

-   virtual void                            MessageReceived(BMessage* msg) override;
+   virtual void                            MessageReceived(BMessage* msg);
Begasus commented 4 years ago

On another not "-lgcov" is gcc8 only afaik: https://github.com/adamfowleruk/Paladin/blob/44887d1fea2a3b3cecf0878dbc531ff09b850630/Tests/compile.sh#L11 Tests are OK on gcc2 without -lgcov there also

kenmays commented 4 years ago

Fixed for Haikuports PR. Patch provided there.

adamfowleruk commented 3 years ago

Thanks for this. I'll ensure that my build testing uses x86 in the pipeline in future. Should catch things like this.