search

HaikuArchives / PecoRename

PecoRename is a powerfull renaming utility, which allows you to rename many files according to a preset pattern.
1 stars 7 forks source link

Update status view when the report window is needed #54

Closed janus2 closed 6 years ago

janus2 commented 6 years ago
humdingerb commented 6 years ago

Works!

Question is: should the "renames" count decrease by the number of failed renames?

conflict

See, there's a "template.recipe" in the same folder leading to the failed rename and the report window. This screenshot is after the report popped up. So the "renames" count should actually be "1", because all else have failed. Before the "Rename", "2 renames" was correct, as the existing "template.recipe" was yet to be discovered.

But I'd take this PR as improvement, if it's not an easy fix... I mean, wo can say no to this one-liner...? :)

janus2 commented 6 years ago

The renames number is always the number of element in the preview column. I don't think should have different behaviors.

humdingerb commented 6 years ago

You're totally right. I misread my own screenshot. :) I just pushed a tiny addition to the ReadMe to make it clearer. Merge: :+1: