search

HaikuArchives / PecoRename

PecoRename is a powerfull renaming utility, which allows you to rename many files according to a preset pattern.
1 stars 7 forks source link

Doesn't replace files when using drag and drop #63

Closed R4H33M closed 3 years ago

R4H33M commented 4 years ago

Fixes #9

humdingerb commented 4 years ago

--> Only the last two files show the correct preview (e.g. with "Insert/overwrite") and are renamed when clicking "Rename".

R4H33M commented 4 years ago

Fixed!

humdingerb commented 4 years ago

Preview works, the actual renaming still only works on the last dropped files. Please test your changes before updating the PR. :)

R4H33M commented 4 years ago

I test extensively before I push, and only push when I am satisfied it works as it should.

the actual renaming still only works on the last dropped files.

It works here. I'm testing on x64, what are using?

scottmc commented 4 years ago

Please also check it out on a 32 bit Haiku, you can do this in a VM, it only take 3 minutes or so to get a new VM up and running. ;)

humdingerb commented 4 years ago

It works here. I'm testing on x64, what are using?

32bit here. A PecoRename built with gcc8 by doing a "setarch x86" crashes when dropping files: https://linx.li/pecorename-1850-debug-17-01-2020-05-35-35.report

R4H33M commented 4 years ago

Please also check it out on a 32 bit Haiku, you can do this in a VM, it only take 3 minutes or so to get a new VM up and running. ;)

Sorry, and good point. I will be testing on both now. But... there is no issues with renaming on x86 for me. It runs as it should.

humdingerb commented 4 years ago

Have you tried renaming files in different folders? That's not working here (32bit, gcc2). I take 4 files from one folder, 4 from another and "Add file extension". only the second 4 files get renamed. Plus a Report window pops up showing the first 4 files with "Unknown error".

janus2 commented 4 years ago

If I remember correctly it's not so simple to add this feature, all the internals assume that the files are in the same directory and the gui does the same. I can be wrong it be so long...

scottmc commented 4 years ago

So is the original issue solved with this PR, partially solved, or nothing new? Should we merge the new code or wait for a full solution which handles the files from different directories issue? Perhaps merge and add new issue?

janus2 commented 4 years ago

This doesn't work at all, the user can add files from different folders but the application doesn't rename the files properly. To implement this feature the app needs major work.

R4H33M commented 4 years ago

To implement this feature the app needs major work.

Should this PR be shelved for the moment then?

humdingerb commented 4 years ago

Should this PR be shelved for the moment then?

I think so, except you got a major brainwave and can make it work. :)

R4H33M commented 4 years ago

Alright. I think we should shelve it - I'll come back to it one day in the near future.

Thanks everyone!

humdingerb commented 4 years ago

Thanks for your work so far! I think we should keep this PR open as it should be a first step to solving the issue.

scottmc commented 3 years ago

Shelving this one. It's here to come back to if there is anything worth using here.