Localization, HTTPS, Paste URL, fixes

[jsteinaker]

Hey, it's been a while.

Apparently, about a year ago I added preliminary support for localization, fixed some crashes and did some minor rework (I honestly can't remember that much). Today I picked up where I left and now the "Paste Shoutcast URL" it's actually working. If you have the station's stream address in the clipboard it will add it to your list. If the address points to a PLS file, it can recover the station's name from there and use it.

Tried and working here.

[KapiX]

@KapiX what's the process to add it to the localization tool?

It depends on who maintains the project:

• People who want to host personal projects can message me or @humdingerb to get developer access in the tool. That allows creating a project and uploading catkeys.
• Projects under HaikuArchives umbrella are maintained by @humdingerb (and sometimes me), though help is welcome.

[humdingerb]

Once this PR is merged, I can give it a quick once-over for sentence casing and then add it to Polyglot.

[jsteinaker]

@pulkomandy many thanks for your review.

I made the changes you suggested. I'll check for a bug report about the BHttpRequest class and I'll fill one if there isn't one already.

As you can see, I enabled the icon search part of the code, and did a minor change so it would compile (that code it's not even mine, I reckon it comes from the original author). The program doesn't hang, but I'm not sure the feature it's working, since most radio streams are not even in the same domain as the Station Home Page, and StreamRadio doesn't have a way to know what's the station URL in those cases. It would be useful to locate a station that actually stores its streams in the same domain as the home page.

Again, thank you very much. I'm learning and to have this kind of reviews is very encouraging.

[jsteinaker]

I've added some minor features that were requested on Issues (help menu, ability to switch between one-stream and multiple streams modes) and updated the spanish catkeys. The features discussed previously should be all working now (if you can excuse the code quality coming from a non-programmer). Can you guys give it a try and confirm if everything is working for you as well?

[Vidrep]

Built and tested on 64 bit. Starting a stream causing a crash. Link to “help” is working ok. If parallel streams are selected, the app freezes up and has to be terminated via TeamMonitor. I’ll try on 32 bit later and report back.

[Vidrep]

tested on 32 bit and features seem to work ok, including parallel playback and help.

[Vidrep]

Went back to 64 bit and compiled again. The problem occurs when you try to use a list of stations from a previously existing install. Deleting the contents of the "Stations" directory, and adding the stations again solves the playback issue.

[jsteinaker]

Thanks for reporting. I've just made a minor bugfix cause I realized the menu wasn't reflecting the parallel playback status on startup (it wasn't being ticked), even when the setting was working OK.

Regarding the crash you're experiencing, I shouldn't have touched anything in the Station class, nor the Stations directory. The config file now stores the parallel playback status, but that's stored on config/settings/StreamRadio.settings

[Vidrep]

humdinger, one of the things we should strive for in HaikuArchives apps is consistency in the menu items. Some apps have a help menu item with a link to a user guide, and the project page. Others have those items listed under "app", some under "file", etc. Some apps are missing these items alltogether.

[jsteinaker]

All done. On the search window, I've noticed that some of the strings are still not translated ("keyword", "country", etc) but I've already done the catkeys at that point. I'll leave those for the next commit, I'll try to get the listenlive.eu service back to work (I think they've moved to radiomap.eu)

[humdingerb]

Thanks, Javier!

Some apps have a help menu item with a link to a user guide, and the project page. Others have those items listed under "app", some under "file", etc. Some apps are missing these items alltogether.

Ideally, yes. If an application has no file related menu items, the 'main' menu with Quit, About, Help etc. should be in a menu named "App". Otherwise those are fine under "File", I suppose. That's at least the tradition...

Those would be easy tasks, with plenty of examples around. If the apps afflicted with these deficiencies were identified, people interested in starting to contribute code could work on it. Or we'd make a few tasks of it for next GCI.