search

HaikuArchives / StreamRadio

Haiku-native application to search for and listen to internet radio stations.
8 stars 11 forks source link

Prepare for a Release...Soon! #27

Open CodeforEvolution opened 4 years ago

CodeforEvolution commented 4 years ago

Now that the application is functional again (with some more functionality too), it’s time to prepare for a release! We’ll also want to update the Haiku Ports recipe to drop the dependency of libxml2, since we parse json only now!

humdingerb commented 4 years ago

Let's wait a few more days. On IRC @Vidrep mentioned a few crashes that appeared after the latest changes. Maybe he'll file a ticket and they might be fixed before a release.

CodeforEvolution commented 4 years ago

Ah, I see, well I’ll keep my eyes open for more tickets! (I may have experienced a crash or two while cleaning up the code too, I just decided that I would wait until the code was clean first...but then I forgot about how to reproduce the crash😅)

kenmays commented 4 years ago

@CodeforEvolution - The current commit works but has a crash when switching channels. I tried a build of your crashEtClean patched branch (https://github.com/HaikuArchives/StreamRadio/pull/34) but ran into the issue below (hrev54643).
g++ -c HttpUtils.cpp -I./ -Iobjects.x86-cc2-release/ -I- -I/boot/system/develop/headers/private/media -I/boot/system/develop/headers/private/media/experimental -I/boot/system/develop/headers/private/shared -O3 -Wall -Wno-multichar -Wno-ctor-dtor-privacy -o "objects.x86-cc2-release/HttpUtils.o" /boot/system/develop/headers/os/net/HttpRequest.h: In methodHttpRequest::HttpRequest(const BUrl &, bool = false, const char = "HTTP", BUrlProtocolListener = 0, BUrlContext = 0)': In file included from /sources/StreamRadio-7c8f73312ba8e560a7660a6223516d8036c6680a/HttpUtils.cpp:22: /boot/system/develop/headers/os/net/HttpRequest.h:68: `BHttpRequest::BHttpRequest(const BUrl &, bool = false, const char = "HTTP", BUrlProtocolListener = 0, BUrlContext = 0)' is private /sources/StreamRadio-7c8f73312ba8e560a7660a6223516d8036c6680a/HttpUtils.h:35: within this context /sources/StreamRadio-7c8f73312ba8e560a7660a6223516d8036c6680a/HttpUtils.cpp: At top level: /sources/StreamRadio-7c8f73312ba8e560a7660a6223516d8036c6680a/HttpUtils.cpp:83: warning: class HttpIOReader' has virtual functions but non-virtual destructor /boot/system/develop/headers/os/net/HttpRequest.h: In methodHttpRequest::HttpRequest(const BUrl &, bool = false, const char = "HTTP", BUrlProtocolListener = 0, BUrlContext = 0)': In file included from /sources/StreamRadio-7c8f73312ba8e560a7660a6223516d8036c6680a/Station.h:30, from /sources/StreamRadio-7c8f73312ba8e560a7660a6223516d8036c6680a/RadioSettings.h:25, from /sources/StreamRadio-7c8f73312ba8e560a7660a6223516d8036c6680a/MainWindow.h:31, from /sources/StreamRadio-7c8f73312ba8e560a7660a6223516d8036c6680a/RadioApp.h:24, from /sources/StreamRadio-7c8f73312ba8e560a7660a6223516d8036c6680a/About.cpp:31: /boot/system/develop/headers/os/net/HttpRequest.h:68: `BHttpRequest::BHttpRequest(const BUrl &, bool = false, const char = "HTTP", BUrlProtocolListener = 0, BUrlContext = 0)' is private /sources/StreamRadio-7c8f73312ba8e560a7660a6223516d8036c6680a/HttpUtils.h:35: within this context /boot/system/develop/etc/makefile-engine:297: recipe for target 'objects.x86-cc2-release/HttpUtils.o' failed make: [objects.x86-cc2-release/HttpUtils.o] Error 1 make: Waiting for unfinished jobs.... /boot/system/develop/etc/makefile-engine:297: recipe for target 'objects.x86-cc2-release/About.o' failed make: *** [objects.x86-cc2-release/About.o] Error 1 Warning: Command '['bash', '-c', '. /wrapper-script']' returned non-zero exit status 2 Error: Build has failed - stopping. `

thaflo commented 3 years ago

Waiting for the "soon" since a while now :-P Have the same compile-problems like kenmays.

humdingerb commented 3 years ago

I think a release only makes sense after that crash is fixed.