HaikuArchives / StreamRadio

Haiku-native application to search for and listen to internet radio stations.
8 stars 11 forks source link

StreamRadio fails to launch or build on nightly builds #3

Closed Vidrep closed 5 years ago

Vidrep commented 5 years ago

After updating to hrev52620+2, "StreamRadio" (installed from HaikuDepot) will not launch anymore. "Could not open "StreamRadio" (Missing symbol: _ZTI10BAdapterIO)."

Attempting to build the StreamRadio package from source also fails with multiple errors.

In file included from StreamPlayer.h:15:0,
                 from StationListView.h:17,
                 from MainWindow.h:31,
                 from MainWindow.cpp:21:
StreamIO.h:28:10: n file included from StreamPlayer.h:15:0,
                 from StationListView.h:17,
                 from MainWindow.h:31,
                 from RadioApp.h:13,
                 from About.c[01;31mfatal error: MediaIO.h: No such file or directory
 #include <MediaIO.h>
          ^~~~~~~~~~~
pp:33:
StreamIO.h:28:10: fatal error: MediaIO.h: No such file or directory
 #include <MediaIO.h>
          ^~~~~~~~~~~
compilation terminated.
Vidrep commented 5 years ago

After setting the new path for MediaIO.h in the makefile, I now get this error:

In file included from StreamPlayer.h:15:0,
                 from StationListView.h:17,
                 from StationFinder.h:24,
                 from RadioApp.cpp:2:
StreamIO.h:82:35: error: expected class-name before ',' token
 class StreamIO : public BAdapterIO, protected BUrlProtocolListener {
                                   ^
StreamIO.h:127:2: error: 'BInputAdapter' does not name a type
  BInputAdapter*      fInputAdapter;
Vidrep commented 5 years ago

Barrett commented on haikuports:

you need to use the headers in "os/codec" Use the BCodecKit namespace where BAdaperIO is used, with the line "using namespace BCodecKit;" link with libcodec.so should be enough, report me about further errors

Begasus commented 5 years ago

Created a PR in regards of the headers, not sure how to fix the error with BCodecKit EDIT added a fix for the build, testers welcome, thanks Barret for the hint :)

Begasus commented 5 years ago

Looks like the move to "os/codec" hasn't been done in the Beta

diversys commented 5 years ago

Works now.