search

HaikuArchives / TakeNotes

Complex note-taking application
12 stars 15 forks source link

Moved replicant dragger hand to lower right corner and updated screenshot. #45

Closed R4H33M closed 4 years ago

R4H33M commented 4 years ago

Fixes #39

humdingerb commented 4 years ago

Looks good, too. The code looks neater than #46...

scottmc commented 4 years ago

Both solutions will be tested to see which one works better. This pull request is cleaner, but other might also be worthy. The other has a few other commits that need to be evaluated as well, so parts of that one might be merged even if this one is as well Please keep these both open until they can be tested. I have merged the 64bit fix.

scottmc commented 4 years ago

Merged the other pull request which also solved this same issue. Solutions were similiar but other one also updated screenshot. Thanks for looking into this even if this solution wasn't the one we merged.

R4H33M commented 4 years ago

@scottmc My screenshot was updated, and was more consistent with the previous one. Arguably looks cleaner too... @humdingerb what do you say?

humdingerb commented 4 years ago

@R4H33M , I'm confused. The screenshot was updated with this PR, and you like it better than the one used before. Do we need to change anything?

scottmc commented 4 years ago

My bad. I think the one that is there now is ok, but ultimately I'd like to see the scroll bar disappear for replicants if it isn't needed, which if/when fixed would need another screenshot. I prefer to have a screenshot that shows it in both modes, but not overlapping or nearly overlapping as the current one does. I've opened a new issue for the scrollbar thing. #48

R4H33M commented 4 years ago

@humdingerb

@R4H33M , I'm confused. The screenshot was updated with this PR, and you like it better than the one used before. Do we need to change anything?

The screenshot was updated with the duplicate PR #46 screenshot which I believe to be a little cluttered and shows more than it should (such as parts of deskbar), compared to how it was before.

@scottmc says he thinks it's okay, and I guess it's not a big deal, so oh well.

R4H33M commented 4 years ago

In fact, the merged code from PR #46 doesn't even pass Haiku's coding guidelines. It doesn't respect the column limit of 80 chars.

humdingerb commented 4 years ago

As the changed file (as probably TakeNote's whole codebase) doesn't follow Haiku's coding style and has longer than 80char lines everywhere anyway, this wasn't a problem. Normally, one adopts the coding style of the file one encounters, so the various code contributions over time don't disrupt the flow if one reads the code.