search

HaikuArchives / Vision

A native Haiku IRC client that is feature filled, fast, lightweight, and stable.
Other
12 stars 16 forks source link

Fix preffered nick list out of bound #15

Closed scythx closed 7 years ago

scythx commented 7 years ago

Fix selected item in preffered nick list that out of bound.

Fixes #10

See ListView that contains name Haikuuser & raefaldhia Left: Before RIght: After screenshot from 2016-12-07 13-22-28

waddlesplash commented 7 years ago

Link to GCI task please.

scythx commented 7 years ago

@waddlesplash https://codein.withgoogle.com/dashboard/task-instances/5157138429116416/ @pulkomandy sorry, I'll describe later because i need to go to school now.

pulkomandy commented 7 years ago

Thanks. It does not seem right to just remove 4 pixels this way. I would prefer to know where the error comes from and why there is an offset in the first place.

scythx commented 7 years ago

@pulkomandy do you know what's version of commit for vision inside haiku nightly build? because that app doesn't contain #10 and #9 so that will make me easier to find out what's the problem between the oldest commit and newer one that produce this bug. and also more cool: screenshot from 2016-12-07 15-39-15

scythx commented 7 years ago

After some hours analyzing this issue just found out that https://github.com/HaikuArchives/Vision/blob/master/src/NetworkPrefsView.cpp#L262 caused the bug, idk what the code supposed to do because without it, vision running fine without #10.

fNickScroller already have correct size without that code.