Open jayant830 opened 6 years ago
Hey, @janus2 sold me it already uses the Locale kit... :) It really should. In the "Preferences" we should add as default something like "Automatic" which will then use the Locale setting. The other options can then be used to override the Locale. Useful, when I want to have one replicant with the weather of a US location, where I may want to see the temperature in °F (in order to communicate with our overseas misfits...) :)
@humdingerb He is talking of geolocalization that Haiku does not support. We use the locale to establish the unit (I hope with the addition of all the other degrees someone has not broken the function)
Then there's a bug somewhere. If I set the Locale prefs to English (US) for Language and Formatting, I still see °C in a newly opened Weather window.
have you delete the settings?
It works for me locale Formatting English (US) -> °F
I now deleted the settings. Forecast is back in the game, thanks. Still don't automatically see °F. Doesn't the "Preferences" setting of Weather override what comes from the Locale prefs?
The app at the first start tries to figure the best choice for the user using the locale Formatting Settings... So if I live in USA I never need to touch the preferences... If the prediction is wrong very improbable I can change the unit in the preferences panel. This is how it works. Very clever if you allow me ;-)
Haiku does support geolocalization. There is a BGeolocalization class for that in the locale kit, IIRC. It is based on https://location.services.mozilla.com , which will locate you based on a scan of Wifi networks within reach.
However, it uses a private key which was only known by olta buildbots, which I think have been retired. We should find another way to securely store that key so that only buildbots can see it in cleartext.
Still, the API is there and can be used. We would be more motivated to keep it working if there are some apps actually using it (I planned to use it to implement HTML5 geoloc at the time, but never got to plugging WebKit to it).
I tried with openGrok can't find this class is spelled wrong?
When I asked three years ago the answer was not service no party!
I don't think geolocation is what we want for Weather. I want to either have it use the unit I set in the Locale prefs, or I want to override it for this specific window/replicant. I don't want it changed depending where I'm currently located (that may be a desired optional feature in Haiku's Locale prefs).
Not for the unit (that should be set according to Locale indeed), but for the initial location when you start the app. That is the point of this particular issue:
App should use location services to determine user's location to display local temperature and weather.
The units are a completely different thing.
Sorry, I apparently took a wrong turn... :)
@humdingerb I'm not totally sure but i think the units work as you expected.
With this feature, someone opening their laptop in Albuquerque or Pismo Beach would have the correct location show up for them. ;)
@humdingerb I'm not totally sure but i think the units work as you expected. It only does on first run. If I change the Locale some time, it won't change. But that's for another issue.
Can we use the GeoClue library for this?, it may not be tide to D-bus and thus can be used as a standalone lib?
As mentionned, Haiu has a BGeolocationClass which does all we need here already.
We could improve it with geoip (currently it only uses wifi networks scanning). No need for ported libs/services such as geoclue however, this is easily implemented natively.
App should use location services to determine user's location to display local temperature and weather.