search

HaikuArchives / ffmpegGUI

GUI for FFmpeg
MIT License
23 stars 10 forks source link

Encoding fails when source or output file names contain spaces #29

Closed andimachovec closed 1 year ago

andimachovec commented 1 year ago

The file names have to be quoted in the ffmpeg commandline which is not the case at the moment

scottmc commented 1 year ago

Also need to test for invalid characters in the filenames and perhaps substitute in "_" or some other char. For example "/" might end up spitting the file and putting the result into a newly create subdirectory. See https://github.com/HaikuArchives/Hare/issues/49 for a similar issue we ran into on Hare.

andimachovec commented 1 year ago

Not sure about replacing the slash character. As of now we have full pathnames in the input and output file name fields, so it's inevitable that they contain slashes.

scottmc commented 1 year ago

Not sure about replacing the slash character. As of now we have full pathnames in the input and output file name fields, so it's inevitable that they contain slashes.

Good point. The slashes in the case of Hare were getting pulled in from the Song names, some of which have slashes in them. That shouldn't be the case here.