search

HaikuArchives / ffmpegGUI

GUI for FFmpeg
MIT License
23 stars 10 forks source link

Resize spinners to fit the values #40

Closed andimachovec closed 1 year ago

andimachovec commented 1 year ago

The minimum required width plus a bit of extra space is set on all the spinners on the main options tab. Fixes #36

scottmc commented 1 year ago

Nice progress. I think you might want to set a min width and height of the window though, as it is now you can shrink the window nearly down to just the App option on the menu. Also I noticed the About window title text and version feels attached to the top left, maybe add same amount of space and the "Written by:" line has. Looking at other apps, I guess this goes away if/when an icon gets added to the About?

andimachovec commented 1 year ago

Thanks. Setting a minimum window size sounds like a good idea. Let me add it to this PR before you merge it. The about window has it's own internal layout, not sure if we can do something here. But like you said, I think the alignment will be OK once we have an icon.

andimachovec commented 1 year ago

I've set the preferred window size on startup as the minimum window size. Could you check if this does what you wanted?

scottmc commented 1 year ago

Better. I would go one more step, that is to set minimum height so that it captures the bottom of the bottom box with text in it.

andimachovec commented 1 year ago

I would go one more step, that is to set minimum height so that it captures the bottom of the bottom box with text in it.

If we do that the user could resize the window to hide the progress bar. I'd rather not allow that.