HaikuArchives / ffmpegGUI

GUI for FFmpeg
MIT License
23 stars 10 forks source link

Minor Layout tweaks #77

Closed humdingerb closed 1 year ago

andimachovec commented 1 year ago

@humdingerb This is great, I think we should remove the "Encode" box as well.

humdingerb commented 1 year ago

I've tried that just now. Here are screenshots: old: http://0x0.st/oFzQ.png new: http://0x0.st/oFz1.png I suggest downloading both and flip back and forth with ShowImage.

What may be the case is that with the "Encode" label, the user's eyes are guided to the "Start" button, while without it the user's brain may throw everything into the options part.

I'm not sure, you can decide...

andimachovec commented 1 year ago

I'm not sure, you can decide...

I like the new one, without the box better. I'm not much of a UI designer but the way I see it a box is there to group UI elements together that belong together function-wise. In our case that makes sense for the boxes around the video, cropping, and audio options, because they have several controls. The encode box only has the text view and the encode button and it's pretty obvious that they belong together, even without the box. Does that make sense? :-)

humdingerb commented 1 year ago

Sure, makes sense. OTOH, the "Encode" BBox isn't really a box around controls, as its side borders have melted into the window border. It functions as a header for that part of the window. Is the Start button + command line still drawing enough attention not to be overlooked? If you say, "Yes", we'll do away with the BBox. :)

andimachovec commented 1 year ago

Yes ;-)

humdingerb commented 1 year ago

So be it. 😃