HaikuTeam / animator

Design tool for creating Lottie animations and interactive web components
https://www.haikuanimator.com/
Other
1.51k stars 157 forks source link

fix: bad logic breaking main row normal collapsed behavior #1016

Closed roperzh closed 5 years ago

roperzh commented 5 years ago

Summary of changes:

When we refactored DnD of timeline rows, we introduced a new helper prop forceCollapse in order to force the rows to be collapsed when a drag is being performed, but since what we really want is to collapse all rows except Main I introduced some faulty logic to handle this specific scenario.

This fixes this logic by not assuming that the Main row has to be always expanded.

Asana Task: https://app.asana.com/0/1114158148688266/1117678624456373

Regressions to look for:

Completed checkin tasks:

stristr commented 5 years ago

LGTM.