Closed jrudolph closed 11 years ago
This one is more of a style check... the two if could really be merged into one.
I agree that sometimes it's more clear to write it as two ifs.
Ah, I completely missed what that message was about. Maybe the message can be changed into: These nested ifs can be merged into one
.
I wouldn't worry to much about what is style and what is a more severe warning but rather make it configurable (I know it's on your list...).
Fixed the wording, and thanks a lot for all the feedback! I'll get to the other issues soon. :+1:
BTW, one more thing that is done already, but isn't documented anywhere - you can ignore warnings with a //nolint comment at the end of the line. But that's only for when you disagree only with a particular instance of a warning - if you disagree with the whole check, it's better to wait for the configuration options, or to wait for a fix, if it's a false positive.
There are two legitimately nested
if
so not sure what this is about:Here's the complete method: