Support for Angular 10.x

rolfback commented 3 years ago

npm WARN ngx-avatar@4.0.0 requires a peer of @angular/common@^9.0.0 but none is installed.

Works fine with Angular 10.x.

odahcam commented 3 years ago

Related: #108

mhosman commented 3 years ago

Angular 11.....

odahcam commented 3 years ago

PRs still welcome guys. Don't forget there are ready to merge PRs that still didn't got merged because we can't currently deploy a new version.

OldShaterhan commented 3 years ago

I'm waiting for update too. It looks to work with Angular 11.

odahcam commented 3 years ago

@OldShaterhan with the current version?

OldShaterhan commented 3 years ago

@odahcam yup, 11.1.1. Probably only change that should be done is package version compatibility and ES target platform (as far as I remember).

Heatmanofurioso commented 3 years ago

This issue could be closed, since support has been added with https://github.com/HaithemMosbahi/ngx-avatar/pull/119

odahcam commented 3 years ago

No, it didn't. The PR was merged but the package was not released, so we still do not have support for Angular 10 unless you build from sources.

mhosman commented 3 years ago

It should be great to give access to any other collaborator to publish new packages

odahcam commented 3 years ago

Yes it should.

Heatmanofurioso commented 3 years ago

This issue can be closed, as the support has been added

Heatmanofurioso commented 2 years ago

@rolfback Can you close the issue since Haithem doesn't seem to be active in the repo anymore, please?

iSatishYadav commented 1 year ago

I am at Angular 10 and can't install with following error:

> npm install
npm ERR! code ERESOLVE
npm ERR! ERESOLVE unable to resolve dependency tree
npm ERR!
npm ERR! While resolving: app@0.0.0
npm ERR! Found: @angular/common@10.2.5
npm ERR! node_modules/@angular/common
npm ERR!   @angular/common@"^10.2.5" from the root project
npm ERR!
npm ERR! Could not resolve dependency:
npm ERR! peer @angular/common@"^9.0.0" from ngx-avatar@4.0.0
npm ERR! node_modules/ngx-avatar
npm ERR!   ngx-avatar@"4.0.0" from the root project
npm ERR!
npm ERR! Fix the upstream dependency conflict, or retry
npm ERR! this command with --force or --legacy-peer-deps
npm ERR! to accept an incorrect (and potentially broken) dependency resolution.

Can't upgrade my Angular to 11 for now, any help is appreciated.

My deps are as follows:

 "dependencies": {
    "@angular/animations": "^10.2.5",
    "@angular/common": "^10.2.5",
    "@angular/compiler": "^10.2.5",
    "@angular/core": "^10.2.5",
    "@angular/forms": "^10.2.5",
    "@angular/platform-browser": "^10.2.5",
    "@angular/platform-browser-dynamic": "^10.2.5",
    "@angular/platform-server": "^10.2.5",
    "@angular/router": "^10.2.5",
    "core-js": "^3.8.3",
    "ngx-avatar": "4.0.0",
    "popper.js": "^1.16.0",
    "rxjs": "^6.6.3",
    "tslib": "^2.0.0",
    "zone.js": "~0.10.2"
  },

OldShaterhan commented 1 year ago

@iSatishYadav, see ngx-avatars on npmjs.

iSatishYadav commented 1 year ago

@iSatishYadav, see ngx-avatars on npmjs.

Apologies. Blunder at my end. Thanks.

HaithemMosbahi / ngx-avatar

Support for Angular 10.x #116