HaitiData / charts-prj

building and display of interactive charts
MIT License
0 stars 2 forks source link

Charts creation #9

Open gmtoglia opened 7 years ago

gmtoglia commented 7 years ago

The first time we create a chart, the result doesn't show up properly, the second time it show up twice.

image

EmereArco commented 7 years ago

Dear Gian Michele, Thank you for your feedback. We are verifing the error. It seems that there problems in generating a bar chart with Chrome. Could you please specify which browser and version are you using? Thank you.

gmtoglia commented 7 years ago

Yes, my Chrome version is: Version 61.0.3163.100 (Official Build) (64-bit). In the following images you can see the behavior on Microsoft Edge and Waterfox. Thank you.

image

EmereArco commented 7 years ago

Dear Gian Michele, the issue has been solved. Please have further test in order to check the proper functioning of the app.

gmtoglia commented 7 years ago

Dear Emere, the test worked very well (on microsft Edge looks different, but we can see this later).

I found that there is a scale error when creating the image. Look what I got when I exported the above mentioned graph:

image

As you can see the values are different.

EmereArco commented 7 years ago

Dear Gian Michele, Have you exported the chart named "Nombre écoles pour typologie de dégât"? I think you have choose GRADE as category, ID as quantity and then SUM as aggregation. And the export is coherent with the chart saved with the title above mentioned. If you want to know how many records there are for each damage classes please use COUNT as aggregation type (as in the chart named "Test"). I hope I have been helpful.

Emere

gmtoglia commented 7 years ago

Yes, I did the test again and you're right, my bad sorry. Question: can we have a control on the title when saving a chart. Now I can save a chart with no title and I think this can lead to confusion. Thank you!

image

EmereArco commented 7 years ago

Yep! When you choose the fields and the aggregation type a suggested title is displayed below the title form. Then if choose to preview the chart and you omit to fill the form, the preview will display the suggested title. Conversely if you fill the title form, the preview will display the title inserted in the form. This behaviour is not implemented when you decide to save the chart. If you fill the form with a title, the chart will be saved with the title you have put in, but if you omit it no title will be saved with chart. This behaviour can be eventually changed, saving the suggested title if no one is given. I leave it to you to make the decision.

gmtoglia commented 7 years ago

Ok, for me we either save the suggested title, either we oblige the user to enter a title (i.e. the title will be a compulsory field -> *Title). Like a "safety" check.

EmereArco commented 7 years ago

I will discuss it with my colleagues next week and I'll keep you posted.

gmtoglia commented 7 years ago

Dear Emere, there is a bug when requesting twice the creation of a graph. In the following video you can see that:

sbsimo commented 7 years ago

Solution proposed in https://github.com/ppasq/haitidata/pull/12 Already merged and published. Re-assigned to @gmtoglia for closing or commenting further.