Haivision / srt

Secure, Reliable, Transport
https://www.srtalliance.org
Mozilla Public License 2.0
3.12k stars 851 forks source link

[BUG] SRT Packet Header bytes must be taken into account for SRTO_MAXREXMITBW #3006

Closed maxsharabayko closed 3 months ago

maxsharabayko commented 3 months ago

Only payload bytes are submitted to CSndRexmitRate.addSample(time_now, 1, w_packet.getLength()). The number of packets is also calculated, but not used in the final rate estimation.

The documentation says packet header bytes must be included:

BW usage limit in Bytes/sec for packet retransmissions (including 16 bytes of SRT header).

SRT v.1.5.3.