search

Haiyang-W / DSVT

[CVPR2023] Official Implementation of "DSVT: Dynamic Sparse Voxel Transformer with Rotated Sets"
https://arxiv.org/abs/2301.06051
Apache License 2.0
353 stars 28 forks source link

add missing to packages #47

Open Krovatkin opened 11 months ago

Krovatkin commented 11 months ago

This PR adds missing __init__.py to any directory with python files, so setup.py can find all packages and install them correctly.

Krovatkin commented 11 months ago

@Haiyang-W Thanks for the great work! I've noticed I can't use this package as a 3rd party dependency installed in site-packages due to setup.py not copying all the python files into the package.

chenshi3 commented 11 months ago

@Krovatkin Thanks for your contribution. I will check and merge this PR.

chenshi3 commented 11 months ago

@Haiyang-W Thanks for the great work! I've noticed I can't use this package as a 3rd party dependency installed in site-packages due to setup.py not copying all the python files into the package.

The __init__.py under the tools folder is not necessary. You may consider deleting these files.

Krovatkin commented 11 months ago

I believe if we remove tools/__init__.py, we won't be able to use any one of these as packages either: 

tools/__init__.py
tools/eval_utils/__init__.py
tools/process_tools/__init__.py
tools/train_utils/__init__.py
tools/visual_utils/__init__.py

Could you please advise me if this behaviour is what we want?

Krovatkin commented 11 months ago

@chenshi3 ^^