HajimeKawahara / exojax

🐈 Automatic differentiable spectrum modeling of exoplanets/brown dwarfs using JAX, compatible with NumPyro and JAXopt
http://secondearths.sakura.ne.jp/exojax/
MIT License
57 stars 14 forks source link

Do we need dtauM_mmwl and dtauCIA_mmwl? #344

Open HajimeKawahara opened 1 year ago

HajimeKawahara commented 1 year ago

As discussed with @chonma0ctopus, we will rethink the necessity of opacity computation with a mmw (mean molecular weight) profile because MMR profile and molecular mass are sufficient to construct the atmospheric abundance profile.

HajimeKawahara commented 1 year ago

any update? @chonma0ctopus I plan to remove these methods in the next release (v1.4) Is it OK?

chonma0ctopus commented 1 year ago

Sorry, no update. It is useful when investigating atomic absorption lines based on VALD using non-uniform layer-by-layer MMR until I'll implement a feature to deal with an array of different atomic masses for each atomic species to this part. (because mmw is independent of atomic species but atomic mass is.)

However, since even I have not been doing such an application recently, you may remove it.

HajimeKawahara commented 1 year ago

OK thanks!

HajimeKawahara commented 1 year ago

@YuiKasagi will use atomic lines for her analysis. Please check if dtauM_mmwl and dtauCIA_mmwl are really needed for the opacity computation of atomic lines. I postpone the decision until v2 release.

chonma0ctopus commented 1 year ago

Thank you @YuiKasagi and @HajimeKawahara. I think those functions are indeed not necessary unless you want to tweak the atomic mixing ratio layer-by-layer. (So, I can accept the option of removing them and redefining them by myself only when doing such a nerdy thing.)