HajimeKawahara / exojax

🐈 Automatic differentiable spectrum modeling of exoplanets/brown dwarfs using JAX, compatible with NumPyro and JAXopt
http://secondearths.sakura.ne.jp/exojax/
MIT License
56 stars 14 forks source link

Rechecks CIA #433

Closed HajimeKawahara closed 9 months ago

HajimeKawahara commented 11 months ago

The CIA is now important for the real retrieval problem. So, we'd like to recheck the CIA. This issue is a part of the #427 code comprehensive review

Related: The current implementation of the CIA was partly validated by comparing with pRT

ykawashima commented 9 months ago

I realized that the difference of the previous comparison with petitRADTRANS also seems to be a few % (due to the inclusion of molecular absorption, the difference looks smaller), which is similar to the one found in the current comparison. I think this issue can be closed.

HajimeKawahara commented 9 months ago

Thank you! I agree.