A side effect related to opa and mdb

[HajimeKawahara]

description:

opa = OpaPremodit uses mdb, but since the temperature setting of OpaPremodit is used within mdb (specifically in change_reference_temperature). Originally, @KoHosokawa pointed that the multiple call of opa with the same mdb changes the first opa. See the sample code #515 (but before this, we needed to define the __eq__ method #509).

opacalc.py

    def apply_params(self):
        self.mdb.change_reference_temperature(self.Tref)

when invoking opa multiple times with the same mdb, the state of opa defined earlier gets altered.

potential solution:

Modify the code so that opa does not alter mdb. Specifically, provide Tref externally from opa and use it to calculate line_strength_ref and qt. This way, Tref is not stored in the internal state of mdb.

i.e. more functional programming like mdb

[HajimeKawahara]

509 #514

[HajimeKawahara]

• removes mdb.Tref
• line_strength_ref_original is line strength at T=Tref_original
• self.line_strength_ref (depending on self.Tref) -> self.line_strength(Tref)
• qr_interp(T) -> qr_interp(T,Tref) in MdbExomol
• qr_interp(iso,T) -> qr_interp(iso,T,Tref) in MdbHitemp/Hitran
• qr_interp_line(T) -> qr_interp_line(T,Tref) in MdbHitemp/Hitran

[HajimeKawahara]

close with #515