Atomic class shoud be reorganized.

HajimeKawahara / exojax

🐈 Automatic differentiable spectrum modeling of exoplanets/brown dwarfs using JAX, compatible with NumPyro and JAXopt

http://secondearths.sakura.ne.jp/exojax/

MIT License

45 stars 14 forks source link

Atomic class shoud be reorganized. #513

Open HajimeKawahara opened 1 month ago

HajimeKawahara commented 1 month ago

I noticed in moldb.py, now there are only atomic databases. We should reorganize Adb classes.

minouHub commented 3 weeks ago

Hello, We have a GSOC working on atomic spectra on the radis side. If you have quick comments to pass before the project is finished, do not hesitate!

Kurucz database - https://github.com/radis/radis/pull/652
NIST database - https://github.com/radis/radis/pull/689

EDIT: sorry for the spam, I thought at first your post was linked to RADIS GSOC but it is not!

HajimeKawahara commented 3 weeks ago

Hello, Great! Are these implementations included as a common API?　 https://github.com/radis/radis/issues/558 If so, ExoJAX will use these capabilities instead of the internal I/O.

minouHub commented 2 weeks ago

Indeed, the objectives of the GSOC were to implement 2 atomic databases in a new common API. The new databases took more time than expected. Thus, for the moment, NIST and Kurucz will be downloaded as we do for HITRAN, ExoMol, and GEISA... but we are still planing on doing the common API!!!