Closed HajimeKawahara closed 1 month ago
177 testsβ Β±0βββ177 :heavy_check_mark: Β±0βββ40s :stopwatch: Β±0s ββββ1 suites Β±0βββββββ0 :zzz: Β±0β ββββ1 filesββ Β±0βββββββ0 :x: Β±0β
Results for commit 04fb330d.βΒ± Comparison against base commit d13bd3ce.
:recycle: This comment has been updated with latest results.
address the side effect raised in #510
The following is a simple test of the side effect:
tests/unittest/opa/sideeffect_test.py
Before this PR (i.e. recent
develop
branch),opa1 == opa1_orig
givesFalse
. This means the second call ofOpaPremodit
using the samemdb
changesopa1.mdb
. In this PR, based on the strategy described in #510, we avoid the side effect, i.e.opa
does not change the internal state ofmdb
.but, we need some modifications:
removed the internal state
mdb.Tref
line_strength_ref_original
was introduced for line strength atT=Tref_original
self.line_strength_ref
(which depends onself.Tref
) ->self.line_strength(Tref)
qr_interp(T)
->qr_interp(T,Tref)
inMdbExomol
qr_interp(iso,T)
->qr_interp(iso,T,Tref)
inMdbHitemp/Hitran
qr_interp_line(T)
->qr_interp_line(T,Tref)
inMdbHitemp/Hitran
The deprecated attribute
Sij0
was removed.