search

HajimeKawahara / jaxsot

JAX implementation of SOT package
http://secondearths.sakura.ne.jp/jaxsot/
MIT License
1 stars 1 forks source link

SOU-L1TSV+VR: preparation: fixed block_coordinate_descent.py #11

Closed atsuki-kuwata closed 2 years ago

atsuki-kuwata commented 2 years ago

in src/jaxsot/core/block_coordinate_descent.py

Functions QP_obj_xk(...) & QP_obj_ak(...): are the same forms, so I integrated them into one function QP_objective(...)

HajimeKawahara commented 2 years ago

Thanks. Can you add a unit test for BCD?

atsuki-kuwata commented 2 years ago

I fixed the files. Please confirm.

HajimeKawahara commented 2 years ago

I confirmed that the test worked well, but it took ~ 30 second, which was a bit long as a very simple unit test. Can you reduce the computation time by changing the parameters? @atsuki-kuwata

atsuki-kuwata commented 2 years ago

Thank you. I will try changing the parameters.

atsuki-kuwata commented 2 years ago

I changed the parameters. The test took ~4 seconds. Is it still long?