Closed dcassol closed 4 years ago
Dear Dani,
thank you so much for these brilliant suggestions!
tibble::data_frame()
call here: https://github.com/HajkD/LTRpred/commit/f9054205c3cd8ff7367958970af82ac8f920fe51
The changes will go live with the new container version of LTRpred
.LTRpred
results from their container back to their local machine: https://github.com/HajkD/LTRpred/commit/c95637ecb23fd56d4f1330b8c04201fcdf7beea6. I hope that everything is according to what you had in mind?
Your help with improving LTRpred
is truly appreciated!
Many thanks, Hajk
Dear @HajkD, Congratulations on the software! I only have three minor points to comment:
https://github.com/HajkD/LTRpred/blob/26bda714253be86c26ac3b178a5da14003b6c4e0/vignettes/Introduction.Rmd#L154 Update to:
docker run --rm -p 8787:8787 -v /put/here/your/path/to/ltrpred_data:/app/ltrpred_data -ti drostlab/ltrpred
https://github.com/HajkD/LTRpred/blob/26bda714253be86c26ac3b178a5da14003b6c4e0/vignettes/Introduction.Rmd#L183
Just a suggestion to update to
tibble()
.https://github.com/HajkD/LTRpred/blob/26bda714253be86c26ac3b178a5da14003b6c4e0/vignettes/Introduction.Rmd#L262 You want to add the link to the section here.
Also, I think you could provide a few details/instructions on how to copy the results from the container to the host.