HajoRijgersberg / OM

Ontology of units of Measure
88 stars 23 forks source link

Fix several errors found with ABECTO #70

Closed jmkeil closed 1 year ago

jmkeil commented 2 years ago

Hi. This fixes several errors found with the comparison using ABECTO (#69).

HajoRijgersberg commented 2 years ago

Hi Jan Martin

Same as with your other pull request, thanx so much and I'll schedule studying it. Again, intended on short terms. Keep you updated!

Cheers, Hajo

HajoRijgersberg commented 1 year ago

My apologies for being so delayed in processing the merge pull requests, which at first had to do with unfamiliarity in Git, which has now improved as I have worked for a year with Git in a professional way with other developers in a software development project. Still learning and still reluctant for the more advanced actions though in Git, I fully admit. I have merged the other pull requests today. Here is a more complex conflict (Git says), and I'm having contact with you, @jmkeil , about this by email. Thanx for detecting the errors with ABECTO so much! That is really a great method and result!

jmkeil commented 1 year ago

The pull request is now on a par with the master branch and can be merged without conflicts.

HajoRijgersberg commented 1 year ago

Thanx so much again, Jan Martin! If I have seen correctly, your ABECTO method has detected and corrected the symbols of microgram per joule: mg/J (and variations) to μg/J (and corresponding variations). This is of course very important; this was a severe error I would say!