search

HajoRijgersberg / OM

Ontology of units of Measure
88 stars 23 forks source link

Dev concentration units #75

Closed sm453 closed 1 year ago

sm453 commented 1 year ago

Added microgram per cubic metre units/classes (in OM namespace!). Added comments to remove TWA namespace definitions, which are only left there for backwards compatibility.

HajoRijgersberg commented 1 year ago

Hi Sebastian,

Thanx for your contribution and my apologies that I haven't seen this and other merge requests... I don't know why I haven't seen them, I think because I received no notifications by email. But I'm very willing to review the proposed changes!

Do I understand correctly that these changes were in a different branch? Were they supposed to be incorporated in the main version of om-2.0.rdf?

If yes, a first question: I see there are a number of theworldavatar.com resource ontouom definitions. Could these perhaps be defined in the OM namespace (or, just for my understanding, why weren't they)?

Many thanx in advance for your response.

Best, Hajo

sm453 commented 1 year ago

Hi Hajo,

Sorry about that - I submitted the pull request by mistake (which is why I closed it again immediately). In my view, our changes are not ready, yet, to go back into the main version of om-2.0.rdf. One of the reasons for that is, as you have noticed, that there are a number of references to theworldavatar.com, which isn't right - they should be defined in the OM namespace. I hope we can clean that up soon.

In any case, thanks for being willing to review.

Best wishes, Seb

HajoRijgersberg commented 1 year ago

Hi Sebastian, Seb,

No problem, thanx for the explanation! :) Glad my seemingly overlooking did not have any implications. Good luck with the further development and looking forward to it!

Cheers, Hajo