HakaiInstitute / hakai-ctd-qc

Series of tests applied to the Hakai CTD profile data based on the QARTOD tests and other Hakai Specific ones.
0 stars 0 forks source link

Add flags declared within the processing stage into QARTOD #7

Closed JessyBarrette closed 1 year ago

JessyBarrette commented 2 years ago

Issue

So issues with the data can't be detected once the data is processed that's why some of those flags were declared during the processing stage inside the process_log. Among there:

The Hakai CTD processing tool doesn't have the ability to send back flag columns. To go around this issue, the flags were included within the processing_log of the RBR processing tool.

Ideally those flags should make it to the Level1 and Level2 flags.

rjbergerud commented 2 years ago

So, we need no_soak and a static_cast_too_short level 1 & 2 flags in ctd.ctd_cast? If so, I'll start tracking an issue in jira for this (though I like github issues, jira just to keep all my todos in one place)

fostermh commented 2 years ago

It seems to be this would be more of a single cast level flag which would indicate the whole cast is suspect because either there was no soak or the static cast was too short. this flag would apply to the whole cast or whole row of data, depending on where it was added, rather than to just one variable/channel as we have done with the other flags.

JessyBarrette commented 2 years ago

Yeah, you're right. Perhaps we can think if of a cast-level data quality flag that would handle the different causes.

Both may have a level 1 and level 2 flag column related to it.

The RBR processing tool can update the processing_flag based on the results. I don't see this being used by the seabird tool.