HakaiInstitute / jsp-time-series-report

Juvenile salmon program annual time series
0 stars 7 forks source link

Survey date restricted for 2015-18 data but not for 2019 data #17

Closed jclgan closed 5 years ago

jclgan commented 5 years ago

https://github.com/HakaiInstitute/jsp-time-series/blob/28013b6ff4119a3c30edacc5440f615a33b191f9/scripts/data_wrangle.Rmd#L54

Why is this filter applied only to 2015-2018 data, but not for 2019 (in code that has yet to be pushed to master)?

Br-Johnson commented 5 years ago

The same filter of date ranges should apply to all years. Feel free to fix the code that reads in 2019 data from the 2019 field data google sheets. When we read all the data from one set of .csv files we can apply the filter once to all years.

jclgan commented 5 years ago

Fixed after merge of feature/julianwrangle