HakanL / WkHtmlToPdf-DotNet

C# .NET Core wrapper for wkhtmltopdf library that uses Webkit engine to convert HTML pages to PDF.
GNU Lesser General Public License v3.0
367 stars 66 forks source link

A callback was made on a garbage collected delegate #1

Closed shodo closed 5 years ago

shodo commented 5 years ago

Hi, I'm using your version and it works great apart from the exception above. I've seen that user rdnr0 has made a branch with a fix for that:

https://github.com/rndusr0/DinkToPdf/commit/a2f8e8e9c74cb953b7c62e4e94c424ba048eb2d3

Is it possibile to merge the fix? Thanks!

HakanL commented 5 years ago

I never tested the callbacks since I don't use that in my application, but I have applied the patch from rndusr0 and uploaded version 1.1.1 to NuGet. Please let me know if that fixed the issue.

shodo commented 5 years ago

I'm not using callback neither, but it's a bug of the internal implementation of the original version of Dink2Pdf. I let you know for sure, thanks a lot!

shodo commented 5 years ago

Hi @HakanL, I've used it for a while, seems it's solved now!

HakanL commented 5 years ago

Thanks for reporting back @shodo!