Closed georgechond94 closed 3 years ago
Very nice, yeah I'm not sure why it was using Cdecl, it was like that in the original repo and I just assumed it was correct. I've tested your PR in Docker and it works fine, and the changes make sense. Thank you very much for your contribution!
This PR allows the wrapper to be used in projects targeting the full .NET Framework.
CallingConvention = CallingConvention.Cdecl
, PInvokeStackImbalance MDA (Managed Debugging Assistants) throws an exception on every P/Invoke call with the message:This is not the case with .NET Core as the MDAs don't exist.
I replaced every
CallingConvention
withCallingConvention.StdCall
(default), which was working fine on my environment (Windows, .NET Framework & Core) but it would be great if you could verify that it's working on every other environment as excepted as well. :smile:/runtimes/win-x
DLLs to the output folder of the referencing application on build, as I couldn't make it to work the same way it does on .NET Core. Current integration with .NET Core isn't affected by that.Closes: #33, #28 (?)