HakanL / WkHtmlToPdf-DotNet

C# .NET Core wrapper for wkhtmltopdf library that uses Webkit engine to convert HTML pages to PDF.
GNU Lesser General Public License v3.0
374 stars 67 forks source link

Adds .NET Framework support #34

Closed georgechond94 closed 3 years ago

georgechond94 commented 3 years ago

This PR allows the wrapper to be used in projects targeting the full .NET Framework.

I replaced every CallingConvention with CallingConvention.StdCall (default), which was working fine on my environment (Windows, .NET Framework & Core) but it would be great if you could verify that it's working on every other environment as excepted as well. :smile:

Closes: #33, #28 (?)

HakanL commented 3 years ago

Very nice, yeah I'm not sure why it was using Cdecl, it was like that in the original repo and I just assumed it was correct. I've tested your PR in Docker and it works fine, and the changes make sense. Thank you very much for your contribution!