search

HakanL / WkHtmlToPdf-DotNet

C# .NET Core wrapper for wkhtmltopdf library that uses Webkit engine to convert HTML pages to PDF.
GNU Lesser General Public License v3.0
367 stars 66 forks source link

Include both 32 bit and 64 bit runtimes in .NET Framework builds #60

Closed mathlang closed 2 years ago

mathlang commented 2 years ago

Updated the build process to copy both x86 and x64 runtimes when building .NET Framework projects. Having only the x86 DLL linked in the project root does not work for AnyCPU assemblies that can run in both 32 bit and 64 bit and needs the proper version of the DLL.

Instead the runtimes folder is copied with only win-x86 and win-x64 runtimes (the others platforms are not supported by .NET Framework)

I believe this will fix issue #58

HakanL commented 2 years ago

There was an issue with the Github build actions, which are fixed in master now. Can you please rebase and update your PR so we can make sure it builds fine before I merge?

HakanL commented 2 years ago

@mathlang Thanks for this commit, I think this fixed the issue with the dll in the root as well. I've added some test projects as well to the main solution to test the various platforms, after this PR it looks pretty good!