Hakky54 / certificate-ripper

🔐 A CLI tool to extract server certificates
Apache License 2.0
714 stars 66 forks source link

Improve nixpkgs example code #25

Closed TomaSajt closed 9 months ago

TomaSajt commented 9 months ago

This PR changes the use of nix-env to nix-shell

It is much more common to use nix-shell and I personally would not recommend nix-env to anyone (even if nixpkgs uses it a lot in the examples)

The updated example will only work if your local version of nixpkgs already has certificate-ripper

Until then, you'd need to write nix-shell -I nixpkgs=https://github.com/NixOS/nixpkgs/archive/master.tar.gz -p certificate-ripper

There are some more modern ways of writing this example, like nix shell nixpkgs#certificate-ripper but that's locked behind an "experimental" flag.

Hakky54 commented 9 months ago

Looks good and it works. Thank you for the PR here and also for the PR on NixOs to get Certificate ripper there! Any idea when the local version will contain the packages?

TomaSajt commented 9 months ago

https://nixpk.gs/pr-tracker.html?pr=276299

Here's a visualization about which branches already contain it. Looks like it has already arrived on nixpkgs-unstable

I don't know if you're using channels or flakes, but either way, updating to unstable should allow you to use it without specifying the repo path.

Or, if we're talking about the stable branches, the next release will be in may.

Hakky54 commented 9 months ago

I am actually not familiar at all with nix packages and nixos. So this is pretty new to me. So I am not using the channels. However it seems like a nice package manager with a big community. So it looks like the command you have provided in this readme will probably work out of the box with the stable release.

Any idea who will keep the packages up to date at the GitHub repo? Or is that also up to the community?

TomaSajt commented 9 months ago

Keeping the packages up to date is done by the community or through automation double-checked by the community. I was planning on managing the version updates in the future.

Hakky54 commented 9 months ago

That is kind of you, thank you very much ♥️