search

HalBuilder / halbuilder-core

HalBuilder Core
38 stars 26 forks source link

ResourceRepresentation::withLinks drops existing links #40

Closed jpommerening closed 7 years ago

jpommerening commented 7 years ago

In ResourceRepresentation the .withLinks method creates a new representation without any of the existing links because the given links list is appended to itself instead of the instance property of the same name.

codecov[bot] commented 7 years ago

Codecov Report

Merging #40 into develop will not change coverage. The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##             develop      #40   +/-   ##
==========================================
  Coverage      72.94%   72.94%           
  Complexity       144      144           
==========================================
  Files              9        9           
  Lines            451      451           
  Branches          48       48           
==========================================
  Hits             329      329           
  Misses            90       90           
  Partials          32       32
Impacted Files Coverage Δ Complexity Δ
...inpractise/halbuilder5/ResourceRepresentation.java 79.59% <100%> (ø) 53 <0> (ø) :arrow_down:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 799335d...fae97a8. Read the comment docs.

talios commented 7 years ago

Cheers - will get a new release out ASAP.