Conflict with EventHorizon-Continued

n-zer commented 6 years ago

Prerequisites

[x] Are you running the latest release of Aurora? If you're using the Twitch updater, make sure the release type is set to "Release" unless told otherwise.
[x] Did you perform a cursory search to see if your bug or enhancement is already reported?

Description

EventHorizon-Continued doesn't load with Aurora enabled.

Steps to Reproduce

Install EventHorizon-Continued
Install Aurora
Enter the game and see that EventHorizon-Continued's main panel doesn't load and the /ehz command isn't recognized.

Additional information

There's a debug value in EventHorizon's config that can be set to true to enable debug logging. It shows that the addon loads, but reads garbage values when trying to initialize, and thus doesn't actually work. This doesn't happen if Aurora is disabled.

Problem started happening recently, didn't happen in an older version of Aurora: [Yes] (though the version I remember it working on was from years ago)
Problem can be reliably reproduced, doesn't happen randomly: [Yes]

Gethe commented 6 years ago

If you don't already have them, install Bugsack and BugGrabber and post any errors you get.

n-zer commented 6 years ago

Looks like Aurora is setting CUSTOM_CLASS_COLORS, which EventHorizon is then attempting to use. But the format doesn't match or something, so EventHorizon breaks. If I change EventHorizon to use RAID_CLASS_COLORS rather than trying CUSTOM_CLASS_COLORS first the problem goes away.

I don't know what CUSTOM_CLASS_COLORS is or what it's supposed to do, so I don't know who's in the wrong here.

Gethe commented 6 years ago

Ok thanks.

CUSTOM_CLASS_COLORS is a community standard to allows addons to modify the class colors without causing issues with the default UI

n-zer commented 6 years ago

So one of these two addons is doing something wrong, and I'm still not sure which one it is. If you can confirm that Aurora is setting CUSTOM_CLASS_COLORS appropriately I can write a fix for EventHorizon.

Gethe commented 6 years ago

It was Aurora. My there was an obscure bug with my implementation that was exposed by EH's particular use of the table. It was fixed with the commit that closed this issue.

n-zer commented 6 years ago

Ah, for some reason I didn't see there was a commit associated with the closing, that's my bad. Thanks for looking at this!

Haleth / Aurora