search

HalfDeadPie / labelord_halfdeadpie

v0.5
Creative Commons Zero v1.0 Universal
0 stars 0 forks source link

Module feedback #4

Open MarekSuchanek opened 7 years ago

MarekSuchanek commented 7 years ago

All tests pass, setup.py and modules seems OK, but I give 4.7 points...

  1. Few unused imports and you sometimes use from ... import * which we discourage to use (see naucse.python.cz/2017/mipyt-zima/intro/distribution/)
  2. When deleting some part of someone else's implementation you need to be careful if it is linked somewhere (in this case static files - css styles are linked from layout.html)