0.10 and various fixes - Githubissues

HalfdanJ / ofxFaceTracker2

Landmark detection addon for openFrameworks using DLIB

Other

209 stars 60 forks source link

0.10 and various fixes #48

Closed micuat closed 6 years ago

micuat commented 6 years ago

this fix includes

glm for oF 0.10 (adapted from https://github.com/HalfdanJ/ofxFaceTracker2/pull/22)
include directory issue from https://github.com/HalfdanJ/ofxFaceTracker2/issues/47
math definition in addon_config.mk for (stupid) visual c++

tested with high sierra + xcode 10 and windows 10 + vs 2017.

okjake commented 6 years ago

Can confirm that this PR fixed the compilation issues I was having on High Sierra

mattfelsen commented 6 years ago

Similarly confirming that this PR helped to compile on Win10 with VS2017 (using the VS2015/v140 toolset) with OF 0.10, ofxFaceTracker2 at latest master (c6de289), and ofxCv at latest master (e1bab46). Thanks! 👍🏼

HalfdanJ commented 6 years ago

Thanks a lot! I dont have the setup to test this at the moment on all the platforms, but taking this as enough evidence for a merge.