search

HalianElf / Deluge-Dark

A dark skin for Deluge WebUI to use with Organizr
MIT License
44 stars 13 forks source link

Change link's href to a jsdelivr one and removed "sub_filter on;" #4

Closed cosmicle0 closed 3 years ago

cosmicle0 commented 3 years ago

I've changed the URL from the github.io one to a jsdelivr one since jsdelivr is a CDN, and I've removed sub_filter on; since it isn't required and won't work in the current versions of nginx.

HalianElf commented 3 years ago

What are you considering "current versions of nginx"? I'm on 1.18 which is current stable and it works fine so it sounds like you just misconfigured something.

cosmicle0 commented 3 years ago

When i have sub_filter on;, I get this: nginxerr

cosmicle0 commented 3 years ago

And yes, I'm on 1.18 too, so I'm not sure why this is happening

cosmicle0 commented 3 years ago

Although it works for me without sub_filter on; so I don't think you need it.

HalianElf commented 3 years ago

It's sub_filter_once on; not just sub_filter on; So you're trying to change my README without even being able to read it. Github pages is also already behind a CDN so I don't see the point in changing the url either. You are free to use whatever you want but I won't be merging this.