Halium / halium-devices

116 stars 210 forks source link

Add Xiaomi Tissot (A1) manifest #288

Closed Tofee closed 3 years ago

Tofee commented 3 years ago

For the setup script, the idea is that we often have missing entries in the proprietary-files.txt files. I don't see any use-case where we wouldn't want to include some of the files in the proprietary vendor repos, so in the setup script I try to add missing files in proprietary-files.txt.

Herrie82 commented 3 years ago

LGTM in general.

Please split into 2 separate PR's. One for the device and one for the generic changes to the setup script.

Tofee commented 3 years ago

Done, only device addition is kept in this PR now

Herrie82 commented 3 years ago

LGTM, tested at my side and works.