search

HallerPatrick / py_lsp.nvim

Lsp Plugin for working with Python virtual environments
97 stars 11 forks source link

Remove 'completion' from on_attach, add capabilities #7

Closed d-miketa closed 2 years ago

d-miketa commented 2 years ago

Hi, thanks for the plugin! I'm currently deciding on my Python workflow and this'll probably make the cut. :) I have two improvements to suggest:

  1. It seems unnecessary to demand the completion plugin. It only appears in the default on_attach setting and can be safely removed.
  2. It'd be good to also expose a capabilities field when passing options to require'lspconfig'.setup as that's where you turn on snippet support.